utkarsharma2 commented on code in PR #36161:
URL: https://github.com/apache/airflow/pull/36161#discussion_r1425078748
##########
airflow/providers/databricks/hooks/databricks_sql.py:
##########
@@ -242,9 +243,11 @@ def run(
@staticmethod
def _make_serializable(result):
- """Transform the databricks Row objects into a JSON-serializable list
of rows."""
- if result is not None:
+ """Transform the databricks Row objects into JSON-serializable
lists."""
+ if isinstance(result, list):
Review Comment:
statement = f"DESCRIBE TABLE {table.name};"
hook.run(statement, parameters=parameters, handler=lambda x: x.fetchall())
with this code `hook.run()` will return `[[val1, val2, val3],[val1, val2,
val3], [val1, val2, val3]]` instead of `[row(), row(), row()]` isn't this a
breaking change??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
