Joffreybvn commented on PR #36161: URL: https://github.com/apache/airflow/pull/36161#issuecomment-1853706099
Just to clarify, the support for fetchall - with the breaking change - was implemented in #32319 . But yes, it is a breaking change. For ODBC, the Row became a NamedTuple - which is a very 'soft' breaking change. For Databricks, there is no NamedTuple because the 'make_serializable' method from #31780, which was turning Row into tuples already, was simply moved down from the Operator into the Hook. Thus, I can make it a NamedTuple too. Adding serialize and deserialize was also discussed in the first PR, and led to [this ADR](https://github.com/apache/airflow/blob/main/airflow/providers/common/sql/doc/adr/0002-return-common-data-structure-from-dbapihook-derived-hooks.md). If Databricks want to comply with it, it should return a tuple / namedtuple. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
