dnskr commented on code in PR #36156:
URL: https://github.com/apache/airflow/pull/36156#discussion_r1427284234
##########
chart/values.yaml:
##########
@@ -2277,8 +2277,6 @@ cleanup:
# Not recommended for production
postgresql:
enabled: true
- image:
- tag: "11"
Review Comment:
Thank you for the review.
There is a good practice to use specific version rather than any sort of
latest version as far as I know. Specific version provides better guarantees
for deployment to be reproduceable and clear expectations on what exactly
should be deployed:
1) Two `bitnami/postgresql` deployments with `{{ .Values.image.tag }} = 16`
might run different database versions. For instance, today it deploys
`16.1.0-debian-11-r15`, but few days ago `16.1.0-debian-11-r13` was deployed
with the same `values.yaml` file.
2) The deployment with `{{ .Values.image.tag }} = 16` not necessarily runs
latest 16 version. For instance, because the chart was deployed a week ago when
`16.1.0-debian-11-r15` didn't exist.
3) Fresh deployment with `{{ .Values.image.tag }} = 16` not necessarily runs
latest 16 version, because docker image with tag 16 might be presented in host
from previous or parallel deployments.
Also, default value from `bitnami/postgres` was used before the
https://github.com/apache/airflow/pull/29207 where 11 version was pinned to
resolve the upgrade issue temporary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
