dstandish commented on a change in pull request #5688: [AIRFLOW-5073] Treat NULL as fail in SQL sensor URL: https://github.com/apache/airflow/pull/5688#discussion_r314968329
########## File path: UPDATING.md ########## @@ -23,6 +23,12 @@ assists users migrating to a new version. ## Airflow Master +### Changes to SqlSensor + +`'None'` is included in success criteria along with `0`, `'0'` and `''`. To preserve +previous behaviour `allow_true` boolean parameter is introduced. It will exclude `'None'` Review comment: >`'None'` is included in success criteria along with `0`, `'0'` and `''`. To preserve What you're actually doing is including `None` in "keep poking" criteria. Previous behavior line is not worded clearly. It excludes `None` from what? Given what value? Should be `allow_null` not `allow_true` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
