dstandish commented on a change in pull request #5688: [AIRFLOW-5073] Treat
NULL as fail in SQL sensor
URL: https://github.com/apache/airflow/pull/5688#discussion_r314968354
##########
File path: airflow/sensors/sql_sensor.py
##########
@@ -28,9 +28,10 @@
class SqlSensor(BaseSensorOperator):
"""
Runs a sql statement repeatedly until a criteria is met. It will keep
trying until
- success or failure criteria are met, or if the first cell is in (0, '0',
''). Optional success
- and failure callables are called with the first cell returned as the
argument. If success
- callable is defined the sensor will keep retrying until the criteria is
met.
+ success or failure criteria are met, or if the first cell is in (0, '0',
'', 'None').
+ An allow_null parameter exclude 'None' results from failure criteria.
Review comment:
> An allow_null parameter exclude 'None' results from failure criteria.
'None' was never part of failure criteria; `None` was implicitly part of the
default _success_ criteria, since it was not on the "keep poking" list, and
success is defined by negation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
