hussein-awala commented on code in PR #36174:
URL: https://github.com/apache/airflow/pull/36174#discussion_r1428939414
##########
chart/values.yaml:
##########
@@ -592,6 +592,28 @@ workers:
# This configuration will be ignored if PGBouncer is not enabled
usePgbouncer: true
+ # Allow HPA (KEDA must be disabled).
+ hpa:
+ enabled: false
+
+ # Minimum number of workers created by HPA
+ minReplicaCount: 0
+
+ # Maximum number of workers created by HPA
+ maxReplicaCount: 10
+
+ # Specifications for which to use to calculate the desired replica count
+ metrics: |-
Review Comment:
IMHO this should be an array of metrics instead of string.
##########
chart/values.schema.json:
##########
@@ -1531,6 +1531,39 @@
}
}
},
+ "hpa": {
+ "description": "HPA configuration.",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "enabled": {
+ "description": "Allow HPA autoscaling (KEDA must
be disabled).",
+ "type": "boolean",
+ "default": false
+ },
+ "minReplicaCount": {
+ "description": "Minimum number of workers created
by KEDA.",
+ "type": "integer",
+ "default": 0
+ },
+ "maxReplicaCount": {
+ "description": "Maximum number of workers created
by KEDA.",
+ "type": "integer",
+ "default": 10
+ },
+ "metrics": {
+ "description": "Specifications for which to use to
calculate the desired replica count.",
+ "type": "string",
Review Comment:
why not an array of metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
