pemiranda-clgx commented on code in PR #36174:
URL: https://github.com/apache/airflow/pull/36174#discussion_r1430707495


##########
chart/values.yaml:
##########
@@ -592,6 +592,28 @@ workers:
     # This configuration will be ignored if PGBouncer is not enabled
     usePgbouncer: true
 
+  # Allow HPA (KEDA must be disabled).
+  hpa:
+    enabled: false
+
+    # Minimum number of workers created by HPA
+    minReplicaCount: 0
+
+    # Maximum number of workers created by HPA
+    maxReplicaCount: 10
+
+    # Specifications for which to use to calculate the desired replica count
+    metrics: |-

Review Comment:
   Hello @hussein-awala, thanks for reviewing. I added metrics as string to 
support `tpl` blocks, just in case someone wants to use parameters from 
`values.yaml`, for example:
   ```yaml
   metrics: |-
     - type: Pods
       pods:
         metric:
           name: executor_running_tasks
         target:
           type: AverageValue
           averageValue: {{ .Values.config.celery.worker_concurrency }}
   ```
   Do you see it feasible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to