amoghrajesh commented on code in PR #35748:
URL: https://github.com/apache/airflow/pull/35748#discussion_r1430916157
##########
chart/templates/_helpers.yaml:
##########
@@ -997,3 +997,27 @@ capabilities:
app: keda-operator
{{- end }}
{{- end }}
+
+{{- define "kubernetesVersion" -}}
+{{ printf "%s" .Capabilities.KubeVersion.Version | trimPrefix "v" }}
+{{- end -}}
+
+{{- define "airflowKerberosContainerArgs" -}}
+{{- $kubectl_version := include "kubernetesVersion" . -}}
+{{- if (semverCompare "<1.28" $kubectl_version) }}
+- airflow
+- kerberos
+- "&"
+- while [ ! -f /opt/kerberos-exit/EXIT ]; do
+ if [ -f /opt/kerberos-exit/EXIT ]; then
+ echo "Exit lockfile found. Exiting kerberos process."
+ break
+ else
+ echo "Exit lockfile not found. Sleeping for 1 second..."
+ sleep 5
+ fi
+ done
+{{- else }}
+- kerberos
Review Comment:
Right, good catch.
Thank you!
##########
chart/templates/_helpers.yaml:
##########
@@ -997,3 +997,27 @@ capabilities:
app: keda-operator
{{- end }}
{{- end }}
+
+{{- define "kubernetesVersion" -}}
+{{ printf "%s" .Capabilities.KubeVersion.Version | trimPrefix "v" }}
+{{- end -}}
+
+{{- define "airflowKerberosContainerArgs" -}}
+{{- $kubectl_version := include "kubernetesVersion" . -}}
+{{- if (semverCompare "<1.28" $kubectl_version) }}
+- airflow
+- kerberos
+- "&"
+- while [ ! -f /opt/kerberos-exit/EXIT ]; do
Review Comment:
Just realised that I didn't push the dockerfile. But i realised there is a
better way of doing it just using YAML. Made the changes, pushing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
