potiuk commented on code in PR #35748:
URL: https://github.com/apache/airflow/pull/35748#discussion_r1431994543
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -232,7 +233,13 @@ spec:
{{- if .Values.workers.command }}
command: {{ tpl (toYaml .Values.workers.command) . | nindent 12 }}
{{- end }}
- {{- if .Values.workers.args }}
+ {{- if and .Values.workers.kerberosSidecar.enabled (semverCompare
"<1.28" $kubeVersion) }}
+ args:
+ {{ tpl (toYaml .Values.workers.args) . | nindent 12 }} &&
Review Comment:
I think this will not work as expected for two reasons:
1) what you can see in the test - `exec airflow celery worker` will replace
the bash interpreter with the python one (this is how exec works) - this means
that whatever is after `&&` will not be executed because bash interpreter will
not be there any more to execute it
2) Even if it did work and we had no exect, this would not work if the
worker crashed and exited with error - because in this case what's after `&&`
is not executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
