bolkedebruin commented on PR #34446:
URL: https://github.com/apache/airflow/pull/34446#issuecomment-1868926624

   Scheme names, which the conn_id translates to when doing `get_uri` are not 
allowed to have a underscore `_` according to RFC3986 
https://datatracker.ietf.org/doc/html/rfc3986#section-3.1 . So imho the warning 
should not be removed as we also transpose the underscore to a hyphen and we 
should educate the user in a friendly way. The RFC even states that we should 
not ignore the error.
   
   Arguably, `get_uri` is not exactly that, but then we should rename it and 
not create confusion on what it does and deviate from the standard.
   
   I suggest closing this and keeping it as is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to