kuikeelc commented on PR #34446: URL: https://github.com/apache/airflow/pull/34446#issuecomment-1868953775
As stated before (please read back): the Conn ID CAN contain underscores. The underscore is labeled an unreserved character as defined in (RFC3968)[ https://datatracker.ietf.org/doc/html/rfc3986#section-2.3] The URI is larger than just the Conn ID. Therefore the warning is false and should be fixed or removed. Op ma 25 dec 2023 om 11:55 schreef bolkedebruin ***@***.***> > Scheme names, which the conn_id translates to when doing get_uri are not > allowed to have a underscore _ according to RFC3986 > https://datatracker.ietf.org/doc/html/rfc3986#section-3.1 . So imho the > warning should not be removed as we also transpose the underscore to a > hyphen and we should educate the user in a friendly way. The RFC even > states that we should not ignore the error. > > Arguably, get_uri is not exactly that, but then we should rename it and > not create confusion on what it does and deviate from the standard. > > I suggest closing this and keeping it as is. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/34446#issuecomment-1868926624>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA2FWCHMEUQWD2XAZWLREJTYLFLTNAVCNFSM6AAAAAA44DIBTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYHEZDMNRSGQ> > . > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
