potiuk commented on code in PR #36410: URL: https://github.com/apache/airflow/pull/36410#discussion_r1436927983
########## docs/apache-airflow/core-concepts/objectstorage.rst: ########## @@ -305,6 +311,27 @@ Airflow needs to walk the directory tree and copy each file individually. This i source to the target. +Caching Review Comment: I think it's fine to keep several unrelated changes in "suppplementary" code - like dev tools etc - we are always cherry-picking pretty much "all" changes there. However in the "core" code it's very important to keep unrelated changes - even documentation ones - separate - because it makes such changes easier cherry-pickable and makes release notes cleaner and easier to follow (those two changes should be mentioned in different sections of the relase notes). Simply speaking - by having unrelated changes in one PR you make your life slightly easier while release manager life quite a lot more complex. So yes, I think it should be split. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
