shohamy7 commented on code in PR #36458:
URL: https://github.com/apache/airflow/pull/36458#discussion_r1437433159
##########
airflow/providers/atlassian/jira/hooks/jira.py:
##########
@@ -60,8 +60,7 @@ def get_conn(self) -> Jira:
# more can be added ex: timeout, cloud, session
# verify
- if "verify" in extra_options and
extra_options["verify"].lower() == "false":
- verify = False
+ verify = bool(extra_options.get("verify", verify))
Review Comment:
@Lee-W
You are right.
I've checked and the `verify` parameter type will be `bool` so we don't need
this.
However, I wonder if this can lead to backward compatibility error. Maybe we
should stick to the old mechanism that uses string instead of bool, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
