eladkal commented on code in PR #36458:
URL: https://github.com/apache/airflow/pull/36458#discussion_r1437446921
##########
airflow/providers/atlassian/jira/hooks/jira.py:
##########
@@ -60,8 +60,7 @@ def get_conn(self) -> Jira:
# more can be added ex: timeout, cloud, session
# verify
- if "verify" in extra_options and
extra_options["verify"].lower() == "false":
- verify = False
+ verify = bool(extra_options.get("verify", verify))
Review Comment:
I prefer to deprecate first. We can accept both bool and string. Make the
necessary adjustments under the hood. For the old style to raise deprecation
warning and then remove completely in next major release.
For cases where we can't deprecate first and we can introduce breaking
change directly (we prefer not to do this but if we must we can)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
