romsharon98 commented on code in PR #36529:
URL: https://github.com/apache/airflow/pull/36529#discussion_r1440745571
##########
airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -151,7 +151,7 @@ def __init__(
self.ci_conn_id = ci_conn_id
self.resource_group = resource_group
- self.name = self._check_name(name)
+ self.name = name
Review Comment:
Thanks @dirrao for your comment 😄
I looked at it again and look it already there.
https://github.com/apache/airflow/blob/59c76cfb3036fab16cef0d70bab052db1fd7f1f9/airflow/providers/microsoft/azure/operators/container_instances.py#L189
Althogh `self._check_name` return a value
https://github.com/apache/airflow/blob/59c76cfb3036fab16cef0d70bab052db1fd7f1f9/airflow/providers/microsoft/azure/operators/container_instances.py#L372-L381
It's look like it don't change `name` any time.
But maybe to avoid future mistakes changing to this `self.name =
self._check_name(self.name)` will be better.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
