josh-fell commented on code in PR #36529:
URL: https://github.com/apache/airflow/pull/36529#discussion_r1442994936
##########
airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -151,7 +151,7 @@ def __init__(
self.ci_conn_id = ci_conn_id
self.resource_group = resource_group
- self.name = self._check_name(name)
+ self.name = name
Review Comment:
Presumably the check in the constructor was to fail faster, but it's
completely fine to just leave the `_check_name()` call in `execute()`.
Although, you don't need the first branch that checks if the `name` arg is a
Jinja template. The value will be rendered _just_ before `execute()` is called
so this logic will never be reached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
