potiuk commented on code in PR #36537:
URL: https://github.com/apache/airflow/pull/36537#discussion_r1441547299
##########
.github/workflows/ci.yml:
##########
@@ -881,8 +881,9 @@ jobs:
path: old-airflow
- name: "Prepare airflow package: wheel"
run: |
- pip install pip==23.3.2 wheel==0.36.2 gitpython==3.1.40
- python setup.py egg_info --tag-build ".dev0" bdist_wheel -d ../dist
+ pip install pip==23.3.2 hatch==1.9.1
Review Comment:
We had experience with `pip` breaking things and I generally prefer to
upgrade it manually - especially when it comes to eager upgrade and dependency
resolution - which is crucial part of the build
It's 2/quarter thiing and we usually do it few days after it's released -
though yeah over last 1.5 year or so it was a painless upgrade every time.
The one "good" side of it is also full reproduicibility - we want to be able
to fully reproduce installation of airflow - including the past images. Which
means that all our builds shoudl be reproducible even 5 years from now.
This is why I am also going to still iterate on that PR and add
reproducibility (including fixing hatchling version and any other build
dependencies I think) - but I would need to automate that part because this one
I want to be fixed at release time but automatically upgradeable at build time.
Maybe that will be a good time to introduce it also for `pip` and any other
`build-needed` dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
