potiuk commented on code in PR #36537:
URL: https://github.com/apache/airflow/pull/36537#discussion_r1442138728
##########
.github/workflows/ci.yml:
##########
@@ -881,8 +881,9 @@ jobs:
path: old-airflow
- name: "Prepare airflow package: wheel"
run: |
- pip install pip==23.3.2 wheel==0.36.2 gitpython==3.1.40
- python setup.py egg_info --tag-build ".dev0" bdist_wheel -d ../dist
+ pip install pip==23.3.2 hatch==1.9.1
Review Comment:
> Pip does explictly introduce breaking changes, e.g. when
https://github.com/pypa/pip/pull/12300 lands very old versions of airflow will
not be installable from the latest Pip. So I agree, applications should
generally pin their Pip version.
Indeed. That's also another reason why I am doing that change now because I
know the longer we wait, the more likely it is for us to get it broken
(especially that we abused setuptools and installation behaviour big time).
And the calver-like versionig of `pip` indeed is clear about being able to
break things (that's what we already saw.... So I want to get Airflow to be as
close to PEP-standards as possible finally to avoid it :).
Also one other thing - I am personally following very closely what happens
in `pip` repo - as we rely a lot of some of the features and miss a few, so I
also use every release of `pip` as an oppotunity to review what's new and
what's changed to know how it impacts us.
Simply `pip` is one of those dependencies for us that we want to **really**
rely on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
