ephraimbuddy commented on code in PR #36744:
URL: https://github.com/apache/airflow/pull/36744#discussion_r1449919628
##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -320,9 +380,10 @@ def publish_release_candidate(version, previous_version,
github_token):
if not github_token:
console_print("GITHUB_TOKEN is not set! Issue generation will
fail.")
confirm_action("Do you want to continue?", abort=True)
- version_suffix = version[5:]
- version_branch = version[:3].replace(".", "-")
- version_without_rc = version[:5]
+
+ version_suffix = airflow_version.pre[0] + str(airflow_version.pre[1])
+ version_branch = str(airflow_version.release[0]) + "_" +
str(airflow_version.release[1])
+ version_without_rc = version.base_version
Review Comment:
```suggestion
version_without_rc = airflow_version.base_version
```
##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -320,9 +380,10 @@ def publish_release_candidate(version, previous_version,
github_token):
if not github_token:
console_print("GITHUB_TOKEN is not set! Issue generation will
fail.")
confirm_action("Do you want to continue?", abort=True)
- version_suffix = version[5:]
- version_branch = version[:3].replace(".", "-")
- version_without_rc = version[:5]
+
+ version_suffix = airflow_version.pre[0] + str(airflow_version.pre[1])
+ version_branch = str(airflow_version.release[0]) + "_" +
str(airflow_version.release[1])
Review Comment:
```suggestion
version_branch = str(airflow_version.release[0]) + "-" +
str(airflow_version.release[1])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
