amoghrajesh commented on code in PR #36744:
URL: https://github.com/apache/airflow/pull/36744#discussion_r1450376620
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -585,16 +585,23 @@ Airflow supports reproducible builds, which means that
the packages prepared fro
produce binary identical packages in reproducible way. You should check if the
packages can be
binary-reproduced when built from the sources.
-Checkout airflow sources and build packages in dist folder:
+Checkout airflow sources and build packages in dist folder (replace X.Y.Zrc1
with the version
+you are checking):
Review Comment:
Nice! Factoring in an example format is good here :)
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -585,16 +585,23 @@ Airflow supports reproducible builds, which means that
the packages prepared fro
produce binary identical packages in reproducible way. You should check if the
packages can be
binary-reproduced when built from the sources.
-Checkout airflow sources and build packages in dist folder:
+Checkout airflow sources and build packages in dist folder (replace X.Y.Zrc1
with the version
+you are checking):
```shell script
-git checkout X.Y.Zrc1
+VERSION=X.Y.Zrc1
Review Comment:
`export` not needed?
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -585,16 +585,23 @@ Airflow supports reproducible builds, which means that
the packages prepared fro
produce binary identical packages in reproducible way. You should check if the
packages can be
binary-reproduced when built from the sources.
-Checkout airflow sources and build packages in dist folder:
+Checkout airflow sources and build packages in dist folder (replace X.Y.Zrc1
with the version
+you are checking):
```shell script
-git checkout X.Y.Zrc1
+VERSION=X.Y.Zrc1
+git checkout ${VERSION}
export AIRFLOW_REPO_ROOT=$(pwd)
rm -rf dist/*
-breeze release-management prepare-airflow-package --package-format both
+breeze release-management prepare-airflow-tarball --version ${VERSION}
+breeze release-management prepare-airflow-package --package-format both
--use-local-hatch
```
-That should produce `.whl` and `.tar.gz` packages in dist folder.
+Note that you need to have `hatch` installed in order to build the packages
with the last command.
+If you do not have hatch, you can remove the `--use-local-hatch` flag and it
will build and use
Review Comment:
```suggestion
If you do not have `hatch`, you can remove the `--use-local-hatch` flag and
it will build and use
```
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -352,7 +378,10 @@ def prepare_airflow_packages(
# Copy all files in the dist directory in container to the host dist
directory (note '/.' in SRC)
run_command(["docker", "cp", f"{container_id}:/opt/airflow/dist/.",
"./dist"], check=True)
run_command(["docker", "rm", "--force", container_id], check=True)
- get_console().print("[success]Successfully prepared Airflow package!\n\n")
+ get_console().print("[success]Successfully prepared Airflow packages:")
Review Comment:
Let us have a different log from:
https://github.com/apache/airflow/pull/36744/files#diff-54ea68b5e1e61ac0437df0ab7d99dc508595323b11847a957931e0d9007962d7R319
for easier tracing when it fails?
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -585,16 +585,23 @@ Airflow supports reproducible builds, which means that
the packages prepared fro
produce binary identical packages in reproducible way. You should check if the
packages can be
binary-reproduced when built from the sources.
-Checkout airflow sources and build packages in dist folder:
+Checkout airflow sources and build packages in dist folder (replace X.Y.Zrc1
with the version
+you are checking):
```shell script
-git checkout X.Y.Zrc1
+VERSION=X.Y.Zrc1
+git checkout ${VERSION}
export AIRFLOW_REPO_ROOT=$(pwd)
rm -rf dist/*
-breeze release-management prepare-airflow-package --package-format both
+breeze release-management prepare-airflow-tarball --version ${VERSION}
+breeze release-management prepare-airflow-package --package-format both
--use-local-hatch
```
-That should produce `.whl` and `.tar.gz` packages in dist folder.
+Note that you need to have `hatch` installed in order to build the packages
with the last command.
+If you do not have hatch, you can remove the `--use-local-hatch` flag and it
will build and use
+docker image that has hatch and other necessary tools installed.
Review Comment:
```suggestion
docker image that has `hatch` and other necessary tools installed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
