ambika-garg commented on code in PR #36622:
URL: https://github.com/apache/airflow/pull/36622#discussion_r1453504886


##########
airflow/providers/microsoft/azure/hooks/synapse.py:
##########
@@ -240,56 +291,32 @@ class AzureSynapsePipelineRunException(AirflowException):
     """An exception that indicates a pipeline run failed to complete."""
 
 
-class AzureSynapsePipelineHook(BaseHook):
+class AzureSynapsePipelineHook(BaseAzureSynapseHook):
     """
     A hook to interact with Azure Synapse Pipeline.
 
     :param azure_synapse_conn_id: The :ref:`Azure Synapse connection 
id<howto/connection:synapse>`.
     :param azure_synapse_workspace_dev_endpoint: The Azure Synapse Workspace 
development endpoint.
     """
 
-    conn_type: str = "azure_synapse_pipeline"

Review Comment:
   I'm considering reverting this change and instead adding a deprecation 
warning for the upcoming release. 



##########
airflow/providers/microsoft/azure/hooks/synapse.py:
##########
@@ -240,56 +291,32 @@ class AzureSynapsePipelineRunException(AirflowException):
     """An exception that indicates a pipeline run failed to complete."""
 
 
-class AzureSynapsePipelineHook(BaseHook):
+class AzureSynapsePipelineHook(BaseAzureSynapseHook):
     """
     A hook to interact with Azure Synapse Pipeline.
 
     :param azure_synapse_conn_id: The :ref:`Azure Synapse connection 
id<howto/connection:synapse>`.
     :param azure_synapse_workspace_dev_endpoint: The Azure Synapse Workspace 
development endpoint.
     """
 
-    conn_type: str = "azure_synapse_pipeline"

Review Comment:
   Could you guide me through the process of introducing this breaking change 
and ensuring a smooth transition for users in the major release?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to