eladkal commented on code in PR #36622:
URL: https://github.com/apache/airflow/pull/36622#discussion_r1457115849
##########
airflow/providers/microsoft/azure/hooks/synapse.py:
##########
@@ -240,56 +291,32 @@ class AzureSynapsePipelineRunException(AirflowException):
"""An exception that indicates a pipeline run failed to complete."""
-class AzureSynapsePipelineHook(BaseHook):
+class AzureSynapsePipelineHook(BaseAzureSynapseHook):
"""
A hook to interact with Azure Synapse Pipeline.
:param azure_synapse_conn_id: The :ref:`Azure Synapse connection
id<howto/connection:synapse>`.
:param azure_synapse_workspace_dev_endpoint: The Azure Synapse Workspace
development endpoint.
"""
- conn_type: str = "azure_synapse_pipeline"
Review Comment:
To introduce breaking change you need to add 9.0.0 in `provider.yaml`:
https://github.com/apache/airflow/blob/f6e357a5fcff8c791f9b2e03be968bf63b17e7c5/airflow/providers/microsoft/azure/provider.yaml#L24-L25
And at the top of the change log:
https://github.com/apache/airflow/blob/main/airflow/providers/microsoft/azure/CHANGELOG.rst#changelog
Add 9.0.0 with braking change title
in the content you need to explain the change and provide instructions for
users how to migrate from the previous version to the current version. You can
see the changelog file for examples for previous major versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]