avkirilishin commented on code in PR #36144:
URL: https://github.com/apache/airflow/pull/36144#discussion_r1453974405
##########
airflow/models/dagrun.py:
##########
@@ -272,11 +272,75 @@ def get_state(self):
return self._state
def set_state(self, state: DagRunState) -> None:
+ """Change the state of the DagRan.
Review Comment:
> `set_state` is only used in scheduler & backfill jobs. I don't see how
your changes connect to manually marking dagrun success or failed.
We use property with `set_state`
[here](https://github.com/apache/airflow/blob/fd9d0b0f7de515b661ec459ba66778dc9730cf0f/airflow/models/dagrun.py#L347-L349).
And we modify the state
[here](https://github.com/apache/airflow/blob/fd9d0b0f7de515b661ec459ba66778dc9730cf0f/airflow/api/common/mark_tasks.py#L368).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
