houqp commented on a change in pull request #5857: [AIRFLOW-5251] add missing
typing-extensions dep for py37
URL: https://github.com/apache/airflow/pull/5857#discussion_r316334536
##########
File path: tests/utils/test_helpers.py
##########
@@ -213,7 +214,10 @@ def test_is_in(self):
# python caches small integers, so i is 3 will be True,
# but `big_i is 2 ** 31` is False.
self.assertTrue(helpers.is_in(big_i, test_container))
- self.assertFalse(helpers.is_in(2 ** 31, test_container))
+ if sys.version_info.minor < 7:
+ self.assertFalse(helpers.is_in(2 ** 31, test_container))
+ else:
+ self.assertTrue(helpers.is_in(2 ** 31, test_container))
Review comment:
I will take a stab at that today. Deleting unused code is one of my fav
exercise :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
