ellisms commented on code in PR #37000: URL: https://github.com/apache/airflow/pull/37000#discussion_r1466136887
########## airflow/providers/amazon/aws/operators/neptune.py: ########## @@ -0,0 +1,222 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING, Sequence + +from airflow.configuration import conf +from airflow.providers.amazon.aws.hooks.neptune import NeptuneHook +from airflow.providers.amazon.aws.operators.base_aws import AwsBaseOperator +from airflow.providers.amazon.aws.triggers.neptune import ( + NeptuneClusterAvailableTrigger, + NeptuneClusterStoppedTrigger, +) +from airflow.providers.amazon.aws.utils.mixins import aws_template_fields + +if TYPE_CHECKING: + from airflow.utils.context import Context + +AVAILABLE_STATES = ["available"] +STOPPED_STATES = ["stopped"] + + +class NeptuneStartDbClusterOperator(AwsBaseOperator[NeptuneHook]): + """Starts an Amazon Neptune DB cluster. + + Amazon Neptune Database is a serverless graph database designed for superior scalability + and availability. Neptune Database provides built-in security, continuous backups, and + integrations with other AWS services + + .. seealso:: + For more information on how to use this operator, take a look at the guide: + :ref:`howto/operator:NeptuneStartDbClusterOperator` + + :param db_cluster_id: The DB cluster identifier of the Neptune DB cluster to be started. + :param wait_for_completion: Whether to wait for the cluster to start. (default: True) + :param deferrable: If True, the operator will wait asynchronously for the cluster to start. + This implies waiting for completion. This mode requires aiobotocore module to be installed. + (default: False) + :param waiter_delay: Time in seconds to wait between status checks. + :param waiter_max_attempts: Maximum number of attempts to check for job completion. + :param aws_conn_id: The Airflow connection used for AWS credentials. + If this is ``None`` or empty then the default boto3 behaviour is used. If + running Airflow in a distributed manner and aws_conn_id is None or + empty, then default boto3 configuration would be used (and must be + maintained on each worker node). + :param region_name: AWS region_name. If not specified then the default boto3 behaviour is used. + + :param botocore_config: Configuration dictionary (key-values) for botocore client. See: + https://botocore.amazonaws.com/v1/documentation/api/latest/reference/config.html + :return: dictionary with Neptune cluster id + """ + + aws_hook_class = NeptuneHook + template_fields: Sequence[str] = aws_template_fields("cluster_id") + + def __init__( + self, + db_cluster_id: str, + wait_for_completion: bool = True, + waiter_delay: int = 30, + waiter_max_attempts: int = 60, + deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False), + **kwargs, + ): + super().__init__(**kwargs) + self.cluster_id = db_cluster_id + self.wait_for_completion = wait_for_completion + self.deferrable = deferrable + self.delay = waiter_delay + self.max_attempts = waiter_max_attempts + + """ @cached_property + def hook(self) -> NeptuneHook: + return NeptuneHook(aws_conn_id=self.aws_conn_id) """ Review Comment: Thanks for the confirmation. Pushed changes to remove it completely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
