Taragolis commented on code in PR #37000:
URL: https://github.com/apache/airflow/pull/37000#discussion_r1466218008
##########
tests/providers/amazon/aws/waiters/test_glue_databrew.py:
##########
@@ -66,3 +66,4 @@ def test_job_succeeded(self, mock_describe_job_runs):
]
waiter = GlueDataBrewHook(aws_conn_id=None).get_waiter("job_complete")
waiter.wait(name=self.JOB_NAME, runId=self.RUN_ID,
WaiterConfig={"Delay": 0.2, "MaxAttempts": 2})
+ waiter.wait.assert_called()
Review Comment:
```suggestion
```
`waiter.wait` is not mocked, so assert_called method is not available.
##########
docs/apache-airflow-providers-amazon/operators/neptune.rst:
##########
@@ -0,0 +1,78 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+==============
+Amazon Neptune
+==============
+
+With `AWS Lambda <https://aws.amazon.com/lambda/>`__,
Review Comment:
I guess this line was incidentally added
##########
tests/providers/amazon/aws/triggers/test_neptune.py:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from unittest import mock
+from unittest.mock import AsyncMock
+
+import pytest
+
+from airflow.providers.amazon.aws.triggers.neptune import (
+ NeptuneClusterAvailableTrigger,
+ NeptuneClusterStoppedTrigger,
+)
+from airflow.triggers.base import TriggerEvent
+
+CLUSTER_ID = "test-cluster"
+
+
+class TestNeptuneClusterAvailableTrigger:
+ def test_serialization(self):
+ """
+ Asserts that the TaskStateTrigger correctly serializes its arguments
+ and classpath.
+ """
+ trigger = NeptuneClusterAvailableTrigger(db_cluster_id=CLUSTER_ID)
+ classpath, kwargs = trigger.serialize()
+ assert classpath ==
"airflow.providers.amazon.aws.triggers.neptune.NeptuneClusterAvailableTrigger"
+ assert "db_cluster_id" in kwargs
+ assert kwargs["db_cluster_id"] == CLUSTER_ID
+
+ @pytest.mark.asyncio
+
@mock.patch("airflow.providers.amazon.aws.hooks.neptune.NeptuneHook.get_waiter")
+
@mock.patch("airflow.providers.amazon.aws.hooks.neptune.NeptuneHook.async_conn")
+ async def test_run_success(self, mock_async_conn, mock_get_waiter):
+ mock_async_conn.__aenter__.return_value = "available"
+ mock_get_waiter().wait = AsyncMock()
+ trigger = NeptuneClusterAvailableTrigger(db_cluster_id=CLUSTER_ID)
+ generator = trigger.run()
+ resp = await generator.asend(None)
+
+ assert resp == TriggerEvent({"status": "success", "db_cluster_id":
CLUSTER_ID})
+ assert mock_get_waiter().wait.call_count == 1
+
+
+class TestNeptuneClusterStoppedTrigger:
+ def test_serialization(self):
+ """
+ Asserts that the TaskStateTrigger correctly serializes its arguments
+ and classpath.
+ """
+ trigger = NeptuneClusterStoppedTrigger(db_cluster_id=CLUSTER_ID)
+ classpath, kwargs = trigger.serialize()
+ assert classpath ==
"airflow.providers.amazon.aws.triggers.neptune.NeptuneClusterStoppedTrigger"
+ assert "db_cluster_id" in kwargs
+ assert kwargs["db_cluster_id"] == CLUSTER_ID
+
+ @pytest.mark.asyncio
+
@mock.patch("airflow.providers.amazon.aws.hooks.neptune.NeptuneHook.get_waiter")
+
@mock.patch("airflow.providers.amazon.aws.hooks.neptune.NeptuneHook.async_conn")
+ async def test_run_success(self, mock_async_conn, mock_get_waiter):
+ mock_async_conn.__aenter__.return_value = "stopped"
+ mock_get_waiter().wait = AsyncMock()
+ trigger = NeptuneClusterStoppedTrigger(db_cluster_id=CLUSTER_ID)
+ generator = trigger.run()
+ resp = await generator.asend(None)
+
+ assert resp == TriggerEvent({"status": "success", "db_cluster_id":
CLUSTER_ID})
+ assert mock_get_waiter().wait.call_count == 1
+
+ # @pytest.mark.asyncio
Review Comment:
Some unfinished test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
