BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523868192 Okay, isn't that up to the reviewer to correct? If we were to implement some name enforcement utility, we'd have to first fetch all class definitions from all tests file, check if they start with `Test`, and for the non-Test classes, determine if they should be tests or not? Reason I'm unsure yet is because there are some helper classes here and there e.g. `DummyClass` in `tests/utils/test_decorators.py`. We would need some tricky logic to determine ourselves if such classes are actually tests or not.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
