BasPH commented on issue #5847: [AIRFLOW-5241] Make test class names consistent by starting with Test URL: https://github.com/apache/airflow/pull/5847#issuecomment-523872982 Ok, some more examples: - `Call` in `tests/operators/test_python_operator.py` - `StubClass` in `tests/contrib/operators/test_grpc_operator.py` - `SomeModelView` in `tests/www/test_security.py` All utility classes for the tests. What rule would you apply to such class names to determine if they're test classes or not and should start with `Test` or not? I'd say if there's an `assert` somewhere in a class, it's probably for testing. But it's not waterproof because sometimes there's no `assert` but e.g. `self.assertEqual`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
