o-nikolas commented on code in PR #37137:
URL: https://github.com/apache/airflow/pull/37137#discussion_r1475045195
##########
tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py:
##########
@@ -1147,3 +1148,220 @@ def
test_providing_no_capacity_provider_no_lunch_type_no_cluster_default(self, m
task_kwargs = ecs_executor_config.build_task_kwargs()
assert task_kwargs["launchType"] == "FARGATE"
+
+ @pytest.mark.parametrize(
Review Comment:
The parameterization looks verbose, but I believe this is ultimately the
clearest way to see the exact inputs and output. I at first was creating and
updating the dicts programmatically, but it became incredibly difficult to see
what was actually being tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
