Taragolis commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488793501
########## airflow/providers/pinecone/provider.yaml: ########## @@ -44,7 +44,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some breaking changes. # It's crucial to adhere to the v3.0.0 Migration Guide before the upper-bound limitation can be removed. # https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b - - pinecone-client>=2.2.4,<3.0 + - pinecone-client~=3.0.0 Review Comment: If pinecone maintainers follow semver the minor/feature versions shouldn't introduce breaking changes. I can't find any information that pinecone have a plan to release breaking changes in 3.1. Usual we do not use upper bound limits, only in edge cases: e.g. it is known fact that new major (rarely minor) of SDK will introduce breaking changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
