uranusjr commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1492007495
##########
airflow/providers/fab/auth_manager/security_manager/override.py:
##########
@@ -276,6 +276,7 @@ class
FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):
(permissions.ACTION_CAN_EDIT, permissions.RESOURCE_VARIABLE),
(permissions.ACTION_CAN_DELETE, permissions.RESOURCE_VARIABLE),
(permissions.ACTION_CAN_DELETE, permissions.RESOURCE_XCOM),
+ (permissions.ACTION_CAN_DELETE, permissions.RESOURCE_DATASET),
Review Comment:
Hmm, does this mean a FAB provider upgrade would be necessary for the
endpoints to work?Do we need to do something about this? Documentation? No
quite sure how this works. cc @vincbeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
