Lee-W commented on code in PR #37176:
URL: https://github.com/apache/airflow/pull/37176#discussion_r1492014740
##########
airflow/providers/fab/auth_manager/security_manager/override.py:
##########
@@ -276,6 +276,7 @@ class
FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):
(permissions.ACTION_CAN_EDIT, permissions.RESOURCE_VARIABLE),
(permissions.ACTION_CAN_DELETE, permissions.RESOURCE_VARIABLE),
(permissions.ACTION_CAN_DELETE, permissions.RESOURCE_XCOM),
+ (permissions.ACTION_CAN_DELETE, permissions.RESOURCE_DATASET),
Review Comment:
> does this mean a FAB provider upgrade would be necessary for the endpoints
to work?
I think so
> Do we need to do something about this?
Without this, `@security.requires_access_dataset("DELETE")` won't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
