Taragolis commented on code in PR #37519:
URL: https://github.com/apache/airflow/pull/37519#discussion_r1493806450


##########
airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py:
##########
@@ -556,24 +556,24 @@ def __init__(
                 TypeError("__init__() missing 1 required positional argument: 
'request_filter'")
 
         super().__init__(**kwargs)
-        self.filter = request_filter
+        self.request_filter = request_filter

Review Comment:
   Agree there is should be also. We never know is someone overwrite some logic 
of the operators
   
   ```python
       @property
       @deprecated(
           reason="`filter` is deprecated and will be removed in the future. 
Please use `request_filter` instead.",
           category=AirflowProviderDeprecationWarning,
       )
       def filter(self) -> dict | None:
           """Alias for ``request_filter``, used for compatibility 
(deprecated)."""
           return self.request_filter
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to