pankajastro commented on code in PR #37519:
URL: https://github.com/apache/airflow/pull/37519#discussion_r1494070490
##########
airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py:
##########
@@ -556,24 +556,24 @@ def __init__(
TypeError("__init__() missing 1 required positional argument:
'request_filter'")
super().__init__(**kwargs)
- self.filter = request_filter
+ self.request_filter = request_filter
Review Comment:
the instance variable is usually breaking change because a user might be
using it in an extended class.
@okirialbert I like the code above that @Taragolis has shared. I was
thinking either we should add the above code or remove `filter` param
completely and make `request_filter` required. wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
