Taragolis commented on code in PR #36755: URL: https://github.com/apache/airflow/pull/36755#discussion_r1496210473
########## airflow/__init__.py: ########## @@ -75,6 +75,7 @@ PY39 = sys.version_info >= (3, 9) PY310 = sys.version_info >= (3, 10) PY311 = sys.version_info >= (3, 11) +PY312 = sys.version_info >= (3, 12) Review Comment: We literally use this kind of constants 1 time in core, all other usage in tests https://github.com/apache/airflow/blob/9bf68adfa0d929c4400d3e9f02cd2feaa4932f59/airflow/utils/hashlib_wrapper.py#L26 I guess we do not use it because in some conditions it might be a reason of Circular Import Error. `airflow.settings` imported before we define this constants Should we also drop a support of them, e.g. deprecate and move it into the __getatrr__ for e.g if some of the users detect their python versions by the airflow, which not a part of public Interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
