[
https://issues.apache.org/jira/browse/AIRFLOW-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915286#comment-16915286
]
ASF GitHub Bot commented on AIRFLOW-5309:
-----------------------------------------
nuclearpinguin commented on pull request #5912: [AIRFLOW-5309] Use
assert_called_once or has_calls in tests
URL: https://github.com/apache/airflow/pull/5912
Using mock.assert_call_with method can result in flaky tests (ex. iterating
through dict in python 3.5 which does not store order of elements). That's why
it's better to use assert_called_once_with or has_calls methods.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-5309
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use assert_called_once or has_calls in tests
> --------------------------------------------
>
> Key: AIRFLOW-5309
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5309
> Project: Apache Airflow
> Issue Type: Bug
> Components: tests
> Affects Versions: 1.10.4
> Reporter: Tomasz Urbaszek
> Assignee: Tomasz Urbaszek
> Priority: Major
>
> Using mock.assert_call_with method can result in flaky tests (ex. iterating
> through dict in python 3.5 which does not store order of elements). That's
> why it's better to use assert_called_once_with or has_calls methods.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
