[
https://issues.apache.org/jira/browse/AIRFLOW-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915481#comment-16915481
]
ASF subversion and git services commented on AIRFLOW-5309:
----------------------------------------------------------
Commit 23d104203e28b60a83172949b38f7c27bf947519 in airflow's branch
refs/heads/master from Tomek
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=23d1042 ]
[AIRFLOW-5309] Use assert_called_once or has_calls in tests (#5912)
Using mock.assert_call_with method can result in flaky tests
(ex. iterating through dict in python 3.5 which does not
store order of elements). That's why it's better to
use assert_called_once_with or has_calls methods.
> Use assert_called_once or has_calls in tests
> --------------------------------------------
>
> Key: AIRFLOW-5309
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5309
> Project: Apache Airflow
> Issue Type: Bug
> Components: tests
> Affects Versions: 1.10.4
> Reporter: Tomasz Urbaszek
> Assignee: Tomasz Urbaszek
> Priority: Major
>
> Using mock.assert_call_with method can result in flaky tests (ex. iterating
> through dict in python 3.5 which does not store order of elements). That's
> why it's better to use assert_called_once_with or has_calls methods.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
