VladaZakharova commented on code in PR #37500: URL: https://github.com/apache/airflow/pull/37500#discussion_r1499259311
########## airflow/providers/google/cloud/operators/vertex_ai/generative_model.py: ########## @@ -0,0 +1,181 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""This module contains Google Vertex AI Generative AI operators.""" + +from __future__ import annotations + +from typing import TYPE_CHECKING, Sequence + +from airflow.providers.google.cloud.hooks.vertex_ai.generative_model import GenerativeModelHook +from airflow.providers.google.cloud.operators.cloud_base import GoogleCloudBaseOperator + +if TYPE_CHECKING: + from vertexai.preview.generative_models import ChatSession + + from airflow.utils.context import Context + + +class PromptLanguageModelOperator(GoogleCloudBaseOperator): Review Comment: Can you please describe what is the purpose of having this as a separate operator in separate module? I think we have almost the same functionality in model_service.py so seems like we can extend it? ########## tests/system/providers/google/cloud/vertex_ai/example_vertex_ai_generative_model.py: ########## @@ -0,0 +1,64 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Example Airflow DAG for Google Vertex AI Generative Model prompting. +""" +from __future__ import annotations + +from datetime import datetime + +from airflow import models +from airflow.providers.google.cloud.operators.vertex_ai.generative_model import ( + PromptLanguageModelOperator, + PromptMultimodalModelOperator, +) + +with models.DAG( + dag_id="example_vertex_ai_generative_model_dag", + description="Sample DAG with generative models.", + schedule="@once", + start_date=datetime(2024, 1, 1), + catchup=False, + tags=["example", "vertex_ai", "generative_model"], +) as dag: + # [START how_to_cloud_vertex_ai_prompt_language_model_operator] + prompt_language_model_task = PromptLanguageModelOperator( + task_id="prompt_language_model_task", + project_id="your-project", Review Comment: Please, check examples of other system tests in google provider. Specifically, how we set value for project_id and env_id -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
