CYarros10 commented on code in PR #37500: URL: https://github.com/apache/airflow/pull/37500#discussion_r1499390423
########## airflow/providers/google/cloud/operators/vertex_ai/generative_model.py: ########## @@ -0,0 +1,181 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""This module contains Google Vertex AI Generative AI operators.""" + +from __future__ import annotations + +from typing import TYPE_CHECKING, Sequence + +from airflow.providers.google.cloud.hooks.vertex_ai.generative_model import GenerativeModelHook +from airflow.providers.google.cloud.operators.cloud_base import GoogleCloudBaseOperator + +if TYPE_CHECKING: + from vertexai.preview.generative_models import ChatSession + + from airflow.utils.context import Context + + +class PromptLanguageModelOperator(GoogleCloudBaseOperator): Review Comment: Great question! My interpretation is that the ModelServiceClient (used by ModelServiceHook) is for models that the user is creating, deploying, and maintaining. Whereas the operators in this PR are models that are directly serviced by Google. Say for example I use the ModelServiceClient to list models in my Google Cloud Project, the generative models such as gemini-pro, text-bison, etc. will not be accessible. The ModelServiceHook uses a separate python library `from google.cloud.aiplatform_v1.types` whereas GenerativeModelHook currently uses `from vertexai` There seemed to be separation between the two use cases so I opted to separate for now, with potentially merging down the line when/if Google unifies them into one package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
