o-nikolas commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1500073659
##########
airflow/providers/amazon/aws/auth_manager/avp/facade.py:
##########
@@ -125,62 +130,97 @@ def is_authorized(
return resp["decision"] == "ALLOW"
- def batch_is_authorized(
+ def get_batch_is_authorized_results(
self,
*,
requests: Sequence[IsAuthorizedRequest],
- user: AwsAuthManagerUser | None,
- ) -> bool:
+ user: AwsAuthManagerUser,
+ ):
Review Comment:
missing return type annotation
##########
airflow/providers/amazon/aws/auth_manager/avp/facade.py:
##########
@@ -205,3 +245,25 @@ def _build_context(context: dict | None) -> dict | None:
return {
"contextMap": context,
}
+
+ def _build_is_authorized_request_payload(self, request:
IsAuthorizedRequest, user: AwsAuthManagerUser):
+ """
+ Build payload of individual authorization request send through
``batch_is_authorized`` API.
Review Comment:
This is what I think this is trying to say, is that right?
```suggestion
Build a payload of an individual authorization request that could be
sent through the ``batch_is_authorized`` API.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
