vincbeck commented on code in PR #37627:
URL: https://github.com/apache/airflow/pull/37627#discussion_r1500832207
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -367,7 +367,7 @@ def _is_permitted_dag_id(method: ResourceMethod, methods:
Container[ResourceMeth
if _is_permitted_dag_id("GET", methods, dag_id) or
_is_permitted_dag_id("PUT", methods, dag_id)
}
- def get_permitted_menu_items(self, menu_items: list[MenuItem]) ->
list[MenuItem]:
+ def filter_permitted_menu_items(self, menu_items: list[MenuItem]) ->
list[MenuItem]:
Review Comment:
You're right. I dont think anybody use that interface yet so I thought it
was the good time to do it. I guess your statement "Or we do not care too much
at this stage?" is correct :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
