vincbeck commented on PR #37638: URL: https://github.com/apache/airflow/pull/37638#issuecomment-1961808501
> Hi @vincbeck > > We have defined the scope of **Task 1** in the PR description. Thank you for your previous comments and suggestions to complete this task. There is a part of the proposed solution that we are still unclear. Refferening to [VladaZakharova](https://github.com/VladaZakharova) commented [2 weeks ago](https://github.com/apache/airflow/pull/36052#issuecomment-1930129837) > > > Blueprint is now can't be retrieved from connexion app and there will be always None. > > Find a way to add csrf extension to a newly created blueprint using connexion: to retrieve blueprint object from connexion_app variable to save the current logic (flask_app.extensions["csrf"].exempt(blueprint)) or find a way to add this extension on connexion level(check the documentation for available options). > > In a recent comment [RobbeSneyders](https://github.com/RobbeSneyders) commented [2 days ago](https://github.com/apache/airflow/pull/36052#issuecomment-1958422648) suggested > > > The most future-proof solution would be to move the csfr protection to a middleware such as [this one](https://github.com/simonw/asgi-csrf/tree/main). The skif_if_scope parameter seems to be a replacement for the exempt functionality you're using. > > So, should we still consider moving `flask_app.extensions["csrf"].exempt(blueprint)` in the `set_api_endpoints` method using `appbuilder.app.extensions["csrf"].exempt(api.blueprint)` ? Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
