sudiptob2 commented on PR #37638: URL: https://github.com/apache/airflow/pull/37638#issuecomment-1962060087
### Refinement: Returning `flask_app` instead of `connexion_app` Ref: https://github.com/apache/airflow/pull/37555#discussion_r1496006432 Mentions: @vincbeck We investigated the usage of `create_app()` method and found a few places where we need to call `connexion_app.run()` If we return `flask_app` from the `create_app()` method then maybe it is not possible to handle those use cases. Therefore, we should return `connexion_app`. There might be other ways to handle this, let me know your opinion. **Usage 1:** https://github.com/apache/airflow/blob/0f4babed5a61f9054cc650a518d64e729cb74188/airflow/cli/commands/webserver_command.py#L356-L358 **Usage 2:** https://github.com/apache/airflow/blob/0f4babed5a61f9054cc650a518d64e729cb74188/airflow/cli/commands/internal_api_command.py#L74-L76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
