darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add
params support for awsbatch_operator
URL: https://github.com/apache/airflow/pull/5900#discussion_r317646111
##########
File path: tests/contrib/operators/test_awsbatch_operator.py
##########
@@ -59,7 +61,7 @@ def test_init(self):
self.aws_hook_mock.assert_called_once_with(aws_conn_id=None)
def test_template_fields_overrides(self):
- self.assertEqual(self.batch.template_fields, ('job_name',
'overrides',))
+ self.assertEqual(self.batch.template_fields, ('job_name',
'parameters', 'overrides',))
Review comment:
nit: is the order important? If the 'nit' above is adopted, the test order
changes to a smaller change also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
