darrenleeweber commented on a change in pull request #5900: [AIRFLOW-5313] Add
params support for awsbatch_operator
URL: https://github.com/apache/airflow/pull/5900#discussion_r317646895
##########
File path: tests/contrib/operators/test_awsbatch_operator.py
##########
@@ -94,6 +97,7 @@ def test_execute_with_failures(self):
client_mock.submit_job.assert_called_once_with(
jobQueue='queue',
jobName='51455483-c62c-48ac-9b88-53a6a725baa3',
+ parameters={},
containerOverrides={},
jobDefinition='hello-world'
)
Review comment:
Please add tests for parameter content (esp. the actual default value; the
class itself uses a default of `None`) and test "bad" parameter values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
