Taragolis commented on code in PR #37638:
URL: https://github.com/apache/airflow/pull/37638#discussion_r1502453187
##########
pyproject.toml:
##########
@@ -83,7 +83,7 @@ dependencies = [
# The usage was added in #30596, seemingly only to override and improve
the default error message.
# Either revert that change or find another way, preferably without using
connexion internals.
# This limit can be removed after
https://github.com/apache/airflow/issues/35234 is fixed
- "connexion[flask]>=2.10.0,<3.0",
+ "connexion[flask,uvicorn,swagger-ui]>=3.0",
Review Comment:
Right now we [install swagger via
npm](https://github.com/apache/airflow/pull/28788) package
[`swagger-ui-dist`](https://www.npmjs.com/package/swagger-ui-dist) and attach
it to the Connexion, so we should do one of the action:
- Remove `swagger-ui-dist` and and use
[`swagger-ui-bundle`](https://github.com/spec-first/swagger_ui_bundle) instead.
In this case dependecy bot do not show should we update swagger version or not,
see: https://github.com/apache/airflow/pull/28824
- Do not use
[swagger-ui-bundle](https://github.com/spec-first/swagger_ui_bundle) in this
case we need to provide path to the swagger ui into the Connexion options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
