Taragolis commented on code in PR #37638:
URL: https://github.com/apache/airflow/pull/37638#discussion_r1506618427
##########
airflow/cli/commands/internal_api_command.py:
##########
@@ -101,7 +101,7 @@ def internal_api(args):
"--workers",
str(num_workers),
"--worker-class",
- str(args.workerclass),
+ "uvicorn.workers.UvicornWorker",
Review Comment:
Same here
##########
airflow/cli/commands/webserver_command.py:
##########
@@ -383,7 +383,7 @@ def webserver(args):
"--workers",
str(num_workers),
"--worker-class",
- str(args.workerclass),
+ "uvicorn.workers.UvicornWorker",
Review Comment:
Is this the only one supported worker after switch to the Connexion 3? If so
we still need to get this value from the airflow configuration [`[webserver]
worker_class`](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#worker-class).
It code be changed to default, and if user provide any other values, then
replace it to the `uvicorn.workers.UvicornWorker` with future warning, some
current implementation could be found into the
[`airflow.configuration.AirflowConfigParser.validate`](https://github.com/apache/airflow/blob/f36e1c75dc47dd29ad89d66ce357e333174cd29f/airflow/configuration.py#L717)
In additional newsfragment should be created with [description of
significant changes](https://github.com/apache/airflow/tree/main/newsfragments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
