potiuk commented on a change in pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#discussion_r317780821
########## File path: airflow/migrations/versions/2e541a1dcfed_task_duration.py ########## @@ -24,7 +24,7 @@ Create Date: 2015-10-28 20:38:41.266143 """ - +# pylint: disable=missing-docstring,no-member,too-many-nested-blocks,wrong-import-order,ungrouped-imports Review comment: I wanted to make sure consistent set of disables for all migration scripts. These disables are the same in all the DB migration scripts and how this will work usually is that people will be copy&pasting those most likely. I think we should avoid fixing those migration scripts - they are automatically generated by alembic and fixing them should not be our priority. In this case rather minimising the changes needed is important I believe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
