potiuk commented on a change in pull request #5786: [AIRFLOW-5170]
[AIRFLOW-5256] Consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r320019978
##########
File path:
airflow/migrations/versions/33ae817a1ff4_add_kubernetes_resource_checkpointing.py
##########
@@ -44,11 +44,11 @@ def upgrade():
conn = op.get_bind()
# alembic creates an invalid SQL for mssql and mysql dialects
- if conn.dialect.name in ("mysql"):
+ if conn.dialect.name in {"mysql"}:
Review comment:
I think it was manually modified after it was generated. Which is quite
typical for those kind of scripts/
The migration scripts from Alembic are only generated once and intended to
be slightly modified - when you add/modify existing model. This is typical case
in alembic (similarly in Django's ORM) that it is "mostly generated". After
generating such migration script you modify it manually to account for
different dialects or some exceptional cases, data migration etc. and only
after that you commit such scripts (and possibly modify them later if you need
to add some fixes in the future).
So I think we are perfectly fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
