potiuk commented on PR #37152: URL: https://github.com/apache/airflow/pull/37152#issuecomment-1969173999
I looked a bit closer ... And unfortunately I think there are few problems: 1) Currenlty seems that test failures are ignored (so when pytest exits with error, the script does not exit with error): https://github.com/apache/airflow/actions/runs/8080612432/job/22077745306?pr=37152#step:5:7061 https://github.com/apache/airflow/actions/runs/8080612432/job/22077744261?pr=37152#step:6:4899 ``` def do_commit(self, dbapi_connection): > dbapi_connection.commit() E sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) server closed the connection unexpectedly E This probably means the server terminated abnormally E before or while processing the request. E E (Background on this error at: https://sqlalche.me/e/14/e3q8) ``` > FAILED tests/core/test_impersonation_tests.py::TestImpersonation::test_no_impersonation - sqlalchemy.exc.PendingRollbackError: Can't reconnect until invalid transaction is rolled back. (Background on this error at: https://sqlalche.me/e/14/8s2b) 2) Seems that the way how now coverage works - that flaky impersonation test is triggered very frequently - I checked 4 tests and 3 of them had it. So I think something is not really ok here. It might because we run the way how pytest is run. I think we should fix the exit code and see **really** how often it fails, and maybe we will have a chance to fix the test ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
